If it’s bound to it yes. Upheaval will always crit since it only procs on a crit.
It’s multiplicative. For example, it sounds like you’re thinking of a Lightning character. After all of your -x% Lightning/Elemental resistance are applied:
If the current enemy resistance is above 0, Viper multiplies it by 0.8.
If the current enemy resistance is below 0, Viper multiplies it by 1.2.
Spirit gives you more damage, Cunning gives you more Offensive Ability for hitting/crits easier. Invest in either and Physique as your build needs. Don’t forget gear requirements either.
what if i put most points on Cunning and boost Physical and get about 100% physical damage convert to lightning… will it also get %Lightning Damage modifiers?
No it doesn’t work like that. Imo put all possible points into Physique. Get OA to crit to proc Ultos / Tempest / Korvaak from other sources than Cunning. Leave Spirit / Cunning dumps for where you’re more experienced with the game and mechanics. You may still be dumping everything into Physique then.